Check for duplicates within the submission itself #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: imperfection
A check for duplication between the submission and the libraries already on the list was already done. However, it is possible that submitters will add the same library twice within a single submission. This was not previously checked for. In addition to causing confusion at a later time for people working directly with the list, it's also possible that allowing duplicates into the list could have harmful implications for the indexer or for Library Manager itself. So it's safest to make a check for duplicates within the submission and return a helpful error message, requiring the submission to contain only unique libraries before accepting it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A check for duplication between the submission and the libraries already on the list was already done. However, it is
possible that submitters will add the same library twice within a single submission. This was not previously checked for.
In addition to causing confusion at a later time for people working directly with the list, it's also possible that
allowing duplicates into the list could have harmful implications for the indexer or for Library Manager itself.
So it's safest to make a check for duplicates within the submission and return a helpful error message, requiring the
submission to contain only unique libraries before accepting it.
Demos
(note submission containing duplicate URLs was accepted)
(note submission was rejected until the duplicate URL it contained was removed)